Fixes crash loading combined(cert+key) certs #6642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crash was introduced by f729c9d
Contributor
Author
|
Where #6483 gets merged, this will also need to follow. |
zwoop
approved these changes
Apr 10, 2020
shinrich
approved these changes
Apr 10, 2020
Member
shinrich
left a comment
shinrich
left a comment
There was a problem hiding this comment.
Yes, I just ran into this yesterday too. You beat me to the PR.
Contributor
Author
|
I should add a test to exercise this, but I don't want that to hold up this PR. |
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crash was introduced by f729c9d